[wp-trac] [WordPress Trac] #49922: PHP Compatibility fixes for 5.5

WordPress Trac noreply at wordpress.org
Wed Jun 3 17:16:32 UTC 2020


#49922: PHP Compatibility fixes for 5.5
------------------------------+-------------------------------
 Reporter:  desrosj           |       Owner:  desrosj
     Type:  task (blessed)    |      Status:  assigned
 Priority:  normal            |   Milestone:  5.5
Component:  General           |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  coding-standards
------------------------------+-------------------------------
Changes (by desrosj):

 * keywords:  has-patch => has-patch commit


Comment:

 As always, many thanks @jrf for your fantastic and detailed review! It is
 always appreciated.

 [attachment:"49922.4.diff"] addresses all remaining issues except the ones
 being tackled separately in #49810 and #41750. I reviewed all of the
 ignore statements added so far and none of them would cause a fatal error
 due to a function being removed in newer versions of PHP currently. It's
 possible this could change in PHP 8, but we can address that once it's
 officially in beta/RC.

 I did not address your comment about adding a cache directive. I am going
 to follow up over on #49783 so that is tackled at the same time.

 Also, thanks for detailing the rough plan and high level items for 10.0.0!
 It seems we'll definitely need a new ticket to explore properly supporting
 once everything is finalized, but it seems it should not be a large
 undertaking.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49922#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list