[wp-trac] [WordPress Trac] #49810: Remove workaround for $HTTP_RAW_POST_DATA bug present in PHP < 5.2.2

WordPress Trac noreply at wordpress.org
Wed Jun 3 04:36:13 UTC 2020


#49810: Remove workaround for $HTTP_RAW_POST_DATA bug present in PHP < 5.2.2
-------------------------------------------------+-------------------------
 Reporter:  skoskie                              |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.5
Component:  XML-RPC                              |     Version:  trunk
 Severity:  trivial                              |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:  rest-api
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by TimothyBlynJacobs):

 * focuses:   => rest-api


Comment:

 I don't see how the XML-RPC logic is any different than the REST API
 logic. The request object isn't available immediately, notably for
 authentication. They may be relying on the raw post data to do a signature
 check.

 WooCommerce does something similar to this, but they use
 `WP_REST_Server::get_raw_data()` so they wouldn't be effected:
 https://wpdirectory.net/search/01E9W6WA98EVCS5AFW5KKW89F5 But I think the
 logic still holds for someone wanting to get the raw body before the REST
 request is available or they intentionally want to get data for the global
 request.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49810#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list