[wp-trac] [WordPress Trac] #50268: Improve the plugin/theme auto-update emails

[WordPress Trac]

#50268: Improve the plugin/theme auto-update emails
-------------------------------------------------+-------------------------
 Reporter:  desrosj                              |       Owner:  audrasjb
     Type:  enhancement                          |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.5
Component:  Upgrade/Install                      |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  needs-copy-review has-patch needs-   |     Focuses:  ui-copy
  testing                                        |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  needs-copy-review has-patch => needs-copy-review has-patch
     needs-testing


Comment:

 Thanks for the patch, @audrasjb! I dug a bit deeper and also examined the
 mixed and failure emails. Those already have opening sentences, so I think
 this will be great for bringing the success emails more in line.

 One additional thing to flag is that the success and mixed results emails
 currently have the same subject line. This is a bit concerning because
 someone would have no way of knowing there was a failure unless they
 actually opened and read the email. The subject line should make it clear
 that there was a problem auto-updating something on the site, even if
 there were also successful updates.

 [attachment:"50268.2.diff"] works off of [attachment:"50268.diff"] to
 further refine:

 - Subject lines are now separated out for each combination to avoid the
 need for "and/or". For example, if only plugins were updated, themes will
 no longer be mentioned and the subject will be "Some plugins were
 automatically updated".
 - Some logic was shifted to avoid duplicate code.
 - Moved the admin links for plugins and themes below the list of
 plugins/themes updated so the list of affected items flows a bit better.

 I also tweaked the success introduction added in [attachment:"50268.diff"]
 based on my suggestion above to read `have been updated automatically`
 from `have been automatically updated` to be more consistent with the
 subject lines, and align more with "auto-update".

 I'm not crazy about creating 3 new variables at the top of the function,
 but repeating those conditions also felt wrong.

 An email with successful plugin and theme updates will now read (with the
 subject line "[Site Name] Some plugins and themes were automatically
 updated"):


 {{{
 Howdy! Some plugins and themes have been updated automatically to new
 versions on your site at http://site.test. No further action is needed on
 your part.


 The following plugins were successfully updated:
 - Classic Editor


 The following themes were successfully updated:
 - Twenty Twenty


 To manage plugins on your site, visit the Plugins page: http://site.test
 /wp-admin/plugins.php
 To manage themes on your site, visit the Themes page: http://site.test/wp-
 admin/themes.php


 If you experience any issues or need support, the volunteers in the
 WordPress.org support forums may be able to help.
 https://wordpress.org/support/forums/

 The WordPress Team
 }}}

 An email with failed results will now read (with the subject line "[Site
 Name] Some plugins and themes have failed to update"):

 {{{
 Howdy! Failures occurred when attempting to update plugins and themes on
 your site at http://site.test.

 Please check out your site now. It’s possible that everything is working.
 If it says you need to update, you should do so.


 The following plugins failed to update:
 - Classic Editor


 The following themes failed to update:
 - Twenty Twenty


 To manage plugins on your site, visit the Plugins page: http://site.test
 /wp-admin/plugins.php
 To manage themes on your site, visit the Themes page: http://site.test/wp-
 admin/themes.php


 If you experience any issues or need support, the volunteers in the
 WordPress.org support forums may be able to help.
 https://wordpress.org/support/forums/

 The WordPress Team
 }}}

 An email with mixed results will now read (with the subject line "[Site
 Name] Some plugins and themes have failed to update"):

 {{{
 Howdy! Failures occurred when attempting to update plugins and themes on
 your site at http://site.test.

 Please check out your site now. It’s possible that everything is working.
 If it says you need to update, you should do so.


 The following plugins failed to update:
 - Classic Editor


 The following themes were successfully updated:
 - Twenty Twenty


 To manage plugins on your site, visit the Plugins page: http://site.test
 /wp-admin/plugins.php
 To manage themes on your site, visit the Themes page: http://site.test/wp-
 admin/themes.php


 If you experience any issues or need support, the volunteers in the
 WordPress.org support forums may be able to help.
 https://wordpress.org/support/forums/

 The WordPress Team
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50268#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform