[wp-trac] [WordPress Trac] #48529: Add fields to WP_Block_Type
WordPress Trac
noreply at wordpress.org
Mon Jun 1 11:10:18 UTC 2020
#48529: Add fields to WP_Block_Type
-------------------------------------------------+-------------------------
Reporter: spacedmonkey | Owner:
| spacedmonkey
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.5
Component: Editor | Version: 5.0
Severity: normal | Resolution:
Keywords: has-patch has-dev-note has-unit- | Focuses:
tests commit |
-------------------------------------------------+-------------------------
Comment (by gziolo):
I applied a few changes with the latest patch version uploaded:
- renamed `text_domain` to `textdomain` and changed the default value to
`null` to reflect the fact that it can be ommited
- removed all references to `styleVariations` to continue use `styles`
that existed before
- updated the default value for `attributes` to `null` to make it work
with the logic pointed by @aduth – we can change it later but I would
prefer to keep it out of this ticket because it's very sensitive change
- updated `parent` to allow `null` value and make it the defauk - it makes
it possible to distinguish between `[]` and `null` that can have different
meanings as pointed in
https://github.com/WordPress/gutenberg/pull/22695#issuecomment-635329233
by @aduth
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48529#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list