[wp-trac] [WordPress Trac] #50808: Plugins screen - The view 'Auto-updates Enabled' also counts not supported plugins

[WordPress Trac]

#50808: Plugins screen - The view 'Auto-updates Enabled' also counts not supported
plugins
------------------------------------+-----------------------
 Reporter:  knutsp                  |       Owner:  audrasjb
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  5.5
Component:  Upgrade/Install         |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+-----------------------

Comment (by pbiron):

 after some investigation, it appears that the problem as reported and
 demonstrated in the screenshots JB attached here, **only happens** if a
 site has auto-updates enabled for some plugins that do not hook into the
 Updates API **before updating to RC1 and/or [48669] was committed**, e.g.,
 a site that had been running beta4 or 5.4 w/ the feature plugin.

 Both @audrasjb and I have tested that hypothesis and it seems to be the
 case.  Would love to have someone else check whether it is true.  To do
 that:

 * install RC1 on a fresh site, with at least 1 plugin that **doesn't**
 hook into the API
 * enable auto-updates for 1 or more plugins that **do** hook into the API
 * confirm that the plugins that don't hook into the API are included in
 the count for the `Auto-update disabled` view and displayed in the list
 table when that view is selected

 or, on a site that had auto-updates enabled for some plugins that don't
 hook into the API **before it was updated to RC1**:

 * delete the `auto_update_plugins` from the DB
 * enable auto-updates for 1 or more plugins that do hook into the API
 * confirm that the plugins that don't hook into the API are included in
 the count for the `Auto-update disabled` view (and displayed in the list
 table when that view is selected)

 While the reported behavior is ''technically'' a regression, I suspect it
 will affect **very** few sites.

 But this also raises another question: **should** plugins that don't hook
 into the API be counted as having auto-updates `disabled`?

 My initial thought is that they should **not** be included in either the
 `enabled` nor `disabled` view.  If others agree, then 2 more questions
 come up:

 1. does that need to be fixed for 5.5?
 2. should there be a `Auto-updates not supported` view?

 I think number 2 can certainly be considered a possible enhancement for
 5.5.1.  Not sure about number 1.

 Thoughts?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50808#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform