[wp-trac] [WordPress Trac] #40188: Filter button should not appear when no comments are available in list

[WordPress Trac]

#40188: Filter button should not appear when no comments are available in list
-------------------------------------------------+-------------------------
 Reporter:  swissspidy                           |       Owner:  Jim_Panse
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.5
Component:  Comments                             |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch has-unit-   |     Focuses:  ui,
  tests                                          |  administration
-------------------------------------------------+-------------------------

Comment (by whyisjake):

 @SergeyBiryukov [attachment:40188.4.diff] attached should make the
 conditionals the same.

 > It's also worth noting that `class-wp-posts-list-table.php` and `class-
 wp-ms-sites-list-table.php` don't check `$this->has_items()`, just `!
 empty( $output )`. Would be nice to bring some consistency here.

 Moving this over to #50815 so that it isn't blocked against the 5.5
 milestone.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40188#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform