[wp-trac] [WordPress Trac] #49288: Metabox holders missing their border and "Drag boxes here" text

[WordPress Trac]

#49288: Metabox holders missing their border and "Drag boxes here" text
-------------------------------------+-------------------------------------
 Reporter:  xkon                     |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  reopened
 Priority:  highest omg bbq          |   Milestone:  5.5
Component:  Administration           |     Version:
 Severity:  blocker                  |  Resolution:
 Keywords:  has-screenshots needs-   |     Focuses:  ui, accessibility,
  testing needs-backwards-           |  administration
  compatibility needs-patch          |
-------------------------------------+-------------------------------------

Comment (by azaozz):

 Replying to [comment:71 afercia]:
 > I'm not sure the CSS part is the main backwards compatibility concern

 Yes, looking more now, some of the js changes would need tweaking/fixing.

 > - Previously, the `empty-container` class set via JS was used only on
 the Dashboard and in the `#post-body` layout only for the `side-
 sortables`, only in the 2 columns layout.
 > ...
 > - The lack of a min-height is the reason why it was not possible any
 longer to move a postbox into the `advanced-sortables` area when empty:
 this was a bug, see comment:7

 Right. The drop areas on the old Edit Post screen are actually three.
 However the second and third are always shown together. If I remember
 correctly the reason the third is three is that postboxes added by plugins
 were put by default in it; at the bottom under the editor. Also think at
 some point (over 10 years ago) that area used to be shown separately, but
 now is always shown together with the second area. So when dragging of
 postboxes was added to that screen, the three areas were kept as back-
 compat, but the third was (mostly) disabled. The users could drag boxes
 out but there's no reason for them to add boxes back in it, as they would
 show and work in exactly the same way as when in the second area. In that
 terms the changes here can either maintain the previous behavior or make
 the third area "droppable" again. This won't change how the screen works.

 > - Regardless, this `visible == 1` has an impact also on the `#post-body`
 layout so I think the best option for now is to just restore it.

 Sounds good. Yes, ideally it should have been implemented better.

 > Seems to me the best way to address backwards compatibility. If there's
 consensus, I can turn this into a patch.

 Yes, I think all the outlined reasons and changes make sense (sorry I
 can't be of more help atm, having some health issues).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49288#comment:72>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform