[wp-trac] [WordPress Trac] #50280: Enable auto-updates shows for plugins with no support

[WordPress Trac]

#50280: Enable auto-updates shows for plugins with no support
-------------------------------------------------+-------------------------
 Reporter:  elrae                                |       Owner:  audrasjb
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.5
Component:  Upgrade/Install                      |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback has-dev-note  |     Focuses:  docs,
                                                 |  administration
-------------------------------------------------+-------------------------

Comment (by dd32):

 This morning I've updated [https://github.com/WordPress/wordpress-
 develop/pull/431 PR 431] to take into account some feedback, and to take
 into account a few more scenario's that I feel are important to cover.

 '''Remove the toggle ui when Automatic updates aren't available for the
 plugin'''
 The PR originally showed 'Unavailable' but after the feedback, I decided
 to just remove the content which looks a fair bit cleaner IMHO. That was
 in [https://github.com/WordPress/wordpress-
 develop/pull/431/commits/f12aca06496f9112e367540b48ab9710db9374c6
 f12aca06].

 '''Automatic Updater is disabled'''
 When using the constant `AUTOMATIC_UPDATER_DISABLED` or filter
 `automatic_updater_disabled`, the UI shouldn't be present to suggest that
 automatic updates can be enabled. [https://github.com/WordPress/wordpress-
 develop/pull/431/commits/4aea5094800e7e3222c3559b0bb5b94ecf24c9b3
 4aea5094].
 That has the effect of 100% disabling the automatic updates UI, the column
 isn't shown on the plugins table, etc.
 Similar to using the `plugins_auto_update_enabled` filter which is rather
 badly and confusingly named (It doesn't enable plugin automatic updates,
 only toggles the UI to manage it)

 '''Respect the auto_update_plugin filter'''
 When the auto_update_plugin filter is in use, which we can detect, we
 should flag in the UI and override it so that it doesn't provide a false
 value. There's no point saying "Enable updates" if the filter is going to
 update anyway, and vice versa when a filter is forcibly disabling the
 updates.
 You'll find that in [https://github.com/WordPress/wordpress-
 develop/pull/431/commits/f12aca06496f9112e367540b48ab9710db9374c6
 f12aca06] which is a Work-in-progress but I wanted to push it up for
 discussion sooner than later.

 That's resulted in this, where:
  - Akismet automatic updates are disabled via the filter
  - Hello Dolly automatic updates are enabled via the filter
  - Jetpack is not affected by a filter, and automatic updates are not
 enabled (Actually, it does, because Jetpack Manage is going to update it.
 Unfortunately [https://github.com/Automattic/jetpack/pull/7015 it no
 longer filters the filter], but if this PR lands I'll ensure that happens)
  - Meeting calendar does not support automatic updates.
 [[Image(https://i0.wp.com/cldup.com/cDh93xXpdG.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50280#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform