[wp-trac] [WordPress Trac] #49288: Metabox holders missing their border and "Drag boxes here" text

WordPress Trac noreply at wordpress.org
Mon Jul 27 18:50:12 UTC 2020


#49288: Metabox holders missing their border and "Drag boxes here" text
-------------------------------------+-------------------------------------
 Reporter:  xkon                     |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  reopened
 Priority:  highest omg bbq          |   Milestone:  5.5
Component:  Administration           |     Version:
 Severity:  blocker                  |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  ui, accessibility,
  screenshots needs-testing needs-   |  administration
  backwards-compatibility            |
-------------------------------------+-------------------------------------

Comment (by azaozz):

 Replying to [comment:64 afercia]:
 > I'm all for reviewing better this change in the next release cycle if
 there are concerns for a broad impact on the plugins ecosystem.

 Sorry but I'm not sure how to read this. I hope it doesn't mean "it is
 okay to potentially break up to 7,000 plugins installed on few millions of
 sites in 5.5, then "review" it and maybe fix it after 3-4 months.
 Releasing a WP version with known incompatibilities is... unthinkable?

 > ...to what extent is the HTML and CSS provided by core for specific
 pages really "supported"?

 Not sure if "supported" is the right word here. The wp-admin CSS is loaded
 on all plugins settings screens. It affects these screens, and many
 plugins reuse some parts to do things same way core does.

 Right, this is a separate (complex/tough) conversation, but if fixes to WP
 can maintain backwards compatibility, like in this ticket, they definitely
 should.

 > > This is incorrect. The `#post-body` ID is used in core as a container
 for the writing area
 >
 > Hm, isn't this what I said above? "...used in core to identify the edit
 pages of posts, comments, menu items..."

 Not exactly. The point here is that: "The #post-body ID is used in core as
 a container for the writing area, and is reused by many plugins for the
 same purpose."

 > > the fact that the committed code reverts previous (long time ago) fix
 >
 > I may have missed what this fix was. Asking genuinely, can you please
 clarify when you have a chance?

 The already discussed "bug" introduced here that reverts to showing drop
 area borders when there's nothing to drop there, i.e. there is only one
 visible postbox. As already mentioned few times, it's an edge case for
 core. Now there's evidence that it affects some plugins too. It's not a
 "huge" deal, but will definitely cause some confusion to the users.
 Ideally this should not have been committed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49288#comment:66>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list