[wp-trac] [WordPress Trac] #50766: Not enough padding on "Warning: these page should not be the same!"

[WordPress Trac]

#50766: Not enough padding on "Warning: these page should not be the same!"
-------------------------------------------------+-------------------------
 Reporter:  SergeyBiryukov                       |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.6
Component:  Administration                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  needs-patch good-first-bug has-      |     Focuses:  ui, css
  screenshots                                    |
-------------------------------------------------+-------------------------
Description changed by SergeyBiryukov:

Old description:

> 1. Go to Reading Settings.
> 2. Assign the same page as Homepage and Posts page.
> 3. You'll see the two message: "Settings saved" and "Warning: these page
> should not be the same!".
> 4. The first message has enough padding, while the second one does not.
>
> This is caused by generic form table styles:
> {{{
> .form-table td p {
>     margin-top: 4px;
>     margin-bottom: 0;
> }
> }}}
> taking precedence over
> {{{
> div.error p {
>     margin: 0.5em 0;
>     padding: 2px;
> }
> }}}
>
> Adding a `notice` class to the message fixes the issue.
>
> Note: This also applies to "Warning: these pages should not be the same
> as your Privacy Policy page!" directly below.

New description:

 1. Go to Reading Settings.
 2. Assign the same page as Homepage and Posts page.
 3. You'll see the two messages: "Settings saved" and "Warning: these page
 should not be the same!".
 4. The first message has enough padding, while the second one does not.

 This is caused by generic form table styles:
 {{{
 .form-table td p {
     margin-top: 4px;
     margin-bottom: 0;
 }
 }}}
 taking precedence over
 {{{
 div.error p {
     margin: 0.5em 0;
     padding: 2px;
 }
 }}}

 Adding a `notice` class to the message fixes the issue.

 Note: This also applies to "Warning: these pages should not be the same as
 your Privacy Policy page!" directly below.

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50766#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform