[wp-trac] [WordPress Trac] #50493: more detailed notice for register_rest_route
WordPress Trac
noreply at wordpress.org
Sat Jul 25 15:51:02 UTC 2020
#50493: more detailed notice for register_rest_route
-------------------------------------+-----------------------------
Reporter: Lwangaman | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Future Release
Component: REST API | Version: 5.4.2
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses: rest-api
-------------------------------------+-----------------------------
Comment (by Lwangaman):
I'm seeing that the [https://travis-ci.com/github/WordPress/wordpress-
develop/jobs/364978265 travis job] triggered by the
[https://github.com/WordPress/wordpress-develop/pull/422 pull request for
code review] is failing. Looking into it, it's something about PHP
linting.
It says:
{{{
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
----------------------------------------------------------------------
SOURCE COUNT
----------------------------------------------------------------------
[x] Squiz.Strings.ConcatenationSpacing.PaddingFound 16
----------------------------------------------------------------------
A TOTAL OF 16 SNIFF VIOLATIONS WERE FOUND IN 1 SOURCE
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SOURCES AUTOMATICALLY (16 VIOLATIONS IN TOTAL)
----------------------------------------------------------------------
}}}
I'm not sure what that refers to? I don't see any spacing on any
concatenation operators. Unless it's picking it up from the first patch I
submitted where I was simply appending the new strings to the previous
strings. Other than that I don't see any concatenation spacing. Is there
anything that needs to be fixed? Sorry I'm kind of new to these
workflows...
--
Ticket URL: <https://core.trac.wordpress.org/ticket/50493#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list