[wp-trac] [WordPress Trac] #50662: Indicate when the `auto_update_{$type}` filter is being used
WordPress Trac
noreply at wordpress.org
Thu Jul 23 00:38:03 UTC 2020
#50662: Indicate when the `auto_update_{$type}` filter is being used
-------------------------------------+-----------------------------
Reporter: desrosj | Owner: whyisjake
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 5.5
Component: Site Health | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses: administration
-------------------------------------+-----------------------------
Changes (by dd32):
* status: closed => reopened
* resolution: fixed =>
Comment:
r48548 - FYI, this only passes 1 arg to the auto_update_theme and
auto_update_plugin filters which expects 2 args.
Although a common use-case is to blanket return true/false, it's also
expected to be able to return conditionally based on the plugin/theme
passed to it, for example, see the final example here:
https://wordpress.org/support/article/configuring-automatic-background-
updates/#plugin-theme-updates-via-filter
Causes fatals like this:
Uncaught ArgumentCountError: Too few arguments to function
Jetpack_Autoupdate::autoupdate_theme(), 1 passed in wp-includes/class-wp-
hook.php on line 287 and exactly 2 expected in /plugins/jetpack/class
.jetpack-autoupdate.php:91
--
Ticket URL: <https://core.trac.wordpress.org/ticket/50662#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list