[wp-trac] [WordPress Trac] #50413: Update code and comments to remove "blacklist" and "whitelist"

[WordPress Trac]

#50413: Update code and comments to remove "blacklist" and "whitelist"
---------------------------------------------+-----------------------
 Reporter:  strangerstudios                  |       Owner:  desrosj
     Type:  defect (bug)                     |      Status:  reopened
 Priority:  normal                           |   Milestone:  5.5
Component:  General                          |     Version:
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch needs-dev-note commit  |     Focuses:
---------------------------------------------+-----------------------

Comment (by SergeyBiryukov):

 Replying to [comment:47 desrosj]:
 > https://github.com/WordPress/wordpress-develop/pull/426 incorporates
 @jorbin's suggestion above and includes the changes in
 [attachment:"50413.5.diff"].

 Just noting that "blocklist" is indeed used in other contexts in core,
 e.g. in `js/_enqueues/wp/editor/base.js`. While the context should be
 enough to avoid confusion, I think switching to "disallowed" is clearer
 and would be preferable.

 Some notes on the PR:

 * I think `wp-includes/Requests/SSL.php` should be excluded from the
 changes.
 * Do we also want to rename the "Comment Blocklist" UI option, previously
 renamed in [46820]?
 * While we're at it, instead of renaming `wp_blocklist_check()` to
 `wp_disallowed_list_check()`, which seems too generic, would something
 like `wp_check_comment_disallowed_list()` be a better name? That would
 also be consistent with `wp_check_comment_flood()` and
 `wp_check_comment_data_max_lengths()`.

 Looks good to me otherwise.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50413#comment:48>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform