[wp-trac] [WordPress Trac] #50413: Update code and comments to remove "blacklist" and "whitelist"
WordPress Trac
noreply at wordpress.org
Wed Jul 22 17:14:47 UTC 2020
#50413: Update code and comments to remove "blacklist" and "whitelist"
---------------------------------------------------+-----------------------
Reporter: strangerstudios | Owner: desrosj
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 5.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-dev-note dev-feedback | Focuses:
---------------------------------------------------+-----------------------
Comment (by SergeyBiryukov):
Replying to [comment:38 desrosj]:
> [attachment:"approach-1.diff"] is a first pass at seamlessly switching
the option key to the new one when calling `(get|update|add)_option()`. I
account for both `blacklist_keys` and `comment_whitelist`, which were both
changed to accomplish the goal of this ticket.
I agree that would be the preferred approach for 5.5.
I noticed that `register_setting()` and `unregister_setting()` use
`_deprecated_argument()` for a similar purpose, so
[attachment:"50413.5.diff"] does the same for consistency, and also tweaks
the message a bit to mention the calling function, as well as both old and
new option keys.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/50413#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list