[wp-trac] [WordPress Trac] #50413: Update code and comments to remove "blacklist" and "whitelist"

[WordPress Trac]

#50413: Update code and comments to remove "blacklist" and "whitelist"
---------------------------------------------------+-----------------------
 Reporter:  strangerstudios                        |       Owner:  desrosj
     Type:  defect (bug)                           |      Status:  reopened
 Priority:  normal                                 |   Milestone:  5.5
Component:  General                                |     Version:
 Severity:  normal                                 |  Resolution:
 Keywords:  has-patch needs-dev-note dev-feedback  |     Focuses:
---------------------------------------------------+-----------------------

Comment (by johnjamesjacoby):

 @desrosj Huge thanks for patching this so quickly.

 approach-2.diff is awesome. It is exactly what WordPress needs for these
 rare occurrences where option keys are deprecated. It seems worthwhile to
 consider this for the 5.5 release, pending approval from relevant
 stakeholders. It is complete, and elegant.

 Re: direct database queries and direct cache access, I think it's OK not
 to catch those cases. Specifically, it would make the `550` upgrade
 routine difficult, requiring some kind of core bypass to allow it to do
 its direct query.

 approach-1.diff works for me. It is enough to circumvent the problem as
 I've identified it. It is not ideal, but it is enough.

 🙏

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50413#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform