[wp-trac] [WordPress Trac] #50653: Remove the _doing_it_wrong from WP_Block_Patterns_Registry::unregister()

WordPress Trac noreply at wordpress.org
Tue Jul 21 19:49:58 UTC 2020


#50653: Remove the _doing_it_wrong from WP_Block_Patterns_Registry::unregister()
--------------------------+---------------------
 Reporter:  johnbillion   |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.5
Component:  Editor        |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+---------------------

Comment (by desrosj):

 At first I thought since this would change the data type that is returned,
 it could be a risky change. However, block patterns have not shipped in
 core yet, so I think this is a fine change to make. Only plugins that are
 building off the Gutenberg plugin would potentially have an issue. But the
 chance they are calling `unregister()` incorrectly is probably slim.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50653#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list