[wp-trac] [WordPress Trac] #49288: Metabox holders missing their border and "Drag boxes here" text

[WordPress Trac]

#49288: Metabox holders missing their border and "Drag boxes here" text
-------------------------------------+-------------------------------------
 Reporter:  xkon                     |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  5.5
Component:  Administration           |     Version:
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch has-           |     Focuses:  ui, accessibility,
  screenshots commit                 |  administration
-------------------------------------+-------------------------------------

Comment (by TobiasBg):

 Hi @afercia!

 Thanks for taking a look so quickly!

 This part of the code is some of the oldest in TablePress, so
 unfortunately my memory about design decisions is not the best here :-(

 That `postbox-container-1/2` thing is one of them. The raw framework that
 I used came from edit-form-advanced.php (I think) and that change
 (according to the commit message) is related to #21042. In some tests, the
 order didn't seem to matter anymore (as positioning is solely handled by
 CSS and no longer via HTML code order, which might have played a role back
 then. It does however not seem to have an influence on the now visible
 dropzones.

 I also tested your suggestion of removing the `post-body` ID. This did
 indeed fix the issue of the now visible dropzones. Unfortunately, it
 creates a new problem:
 On the "About" screen of TablePress
 ([https://ps.w.org/tablepress/assets/screenshot-7.png screenshot]), there
 are normally two columns of postboxes. After removing the `post-body` ID,
 everything is in only column, presumably because CSS from common.css
 ([https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/css/common.css#L1960 lines 1960-1968]) no longer applies. So, `post-
 body` seems to be necessary to get a two-column layout.

 The newly introduced arrow buttons seem to work nicely! This really is a
 great improvement of drag&drop, thanks!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49288#comment:53>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform