[wp-trac] [WordPress Trac] #50722: Change params on wp_image_file_matches_image_meta function

WordPress Trac noreply at wordpress.org
Tue Jul 21 16:43:58 UTC 2020


#50722: Change params on wp_image_file_matches_image_meta function
--------------------------------------+-----------------------------
 Reporter:  spacedmonkey              |       Owner:  SergeyBiryukov
     Type:  enhancement               |      Status:  reviewing
 Priority:  normal                    |   Milestone:  5.5
Component:  Media                     |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  rest-api
--------------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => reviewing


Comment:

 If the goal is to provide pass the `$attachment_id` parameter to the
 `wp_image_file_matches_image_meta` filter, it seems like the best way
 forward would be to pass it along with `$image_meta` to the function.

 That would be consistent with a few existing functions:
 * `wp_calculate_image_srcset()`
 * `wp_calculate_image_sizes()`
 * `wp_image_add_srcset_and_sizes()`

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50722#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list