[wp-trac] [WordPress Trac] #50666: Size limit not correctly applied for sitemaps index

WordPress Trac noreply at wordpress.org
Mon Jul 20 21:56:01 UTC 2020


#50666: Size limit not correctly applied for sitemaps index
--------------------------------------+-------------------------
 Reporter:  swissspidy                |       Owner:  swissspidy
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  5.5
Component:  Sitemaps                  |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-------------------------

Comment (by pbiron):

 [attachment:50666.2.diff] is the same as [attachment:50666.diff] except
 for:

 1. `WP_Sitemaps_Index::get_sitemap_list()`: break out of the loop as soon
 as `count( $sitemaps ) >= $this->max_sitemaps`
 2. the new unit test is more explict about what it is testing
    * as part of that, the constructor for the new
 `WP_Sitemaps_Large_Test_Provider` class takes a parameter for how many
 entries the test provider should generate
    * this new parameter may also be useful in future uses of this test
 provider

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50666#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list