[wp-trac] [WordPress Trac] #50683: Parse content for shortcodes instead of using regex

WordPress Trac noreply at wordpress.org
Sun Jul 19 14:06:41 UTC 2020


#50683: Parse content for shortcodes instead of using regex
--------------------------------------+---------------------
 Reporter:  cfinke                    |       Owner:  (none)
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  5.6
Component:  Shortcodes                |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+---------------------

Comment (by SergeyBiryukov):

 > Switching to non-mb_* string functions. The rest of the shortcode code
 doesn't use them, so maybe they aren't necessary.

 Just noting this should ideally be tested with `mbstring.func_overload =
 2` PHP setting, as it is known to have caused some issues in the past:
 #16057, #18007, #25061, #25259, #28162, #38226, #46050, etc.

 It is [https://www.php.net/manual/en/mbstring.overload.php deprecated as
 of PHP 7.2], but may still occur in the wild.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50683#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list