[wp-trac] [WordPress Trac] #50686: UI issue on nav-menus.php

[WordPress Trac]

#50686: UI issue on nav-menus.php
-------------------------------------+-------------------------------------
 Reporter:  dilipbheda               |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Menus                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  ui, accessibility,
  patch                              |  css, administration
-------------------------------------+-------------------------------------
Changes (by sabernhardt):

 * focuses:  ui, css, administration => ui, accessibility, css,
              administration
 * version:  trunk =>


Comment:

 @dilipbheda Thanks for the patch!

 [attachment:"50686.patch"] successfully removes the extra red border from
 the "Create Menu" submit button when the menu name is empty. Likewise,
 that border is no longer on the "Add to Menu" button when a Custom Link's
 URL field is left empty. The date/time selection fields for posts and
 comments can also be inside the container with a `form-invalid` class, but
 the OK buttons are not within the container (so those do not need fixing).

 However, the border is still on the Custom Link's "Link Text" input though
 the error only relates to the empty URL field. Technically, the selectors
 could have another `:not()` to make `.form-invalid input:not(.button):not
 (#custom-menu-item-name)`, yet there probably is a better option.

 I added the accessibility focus so the team could consider more
 substantial feedback for these errors, appearing in close proximity to the
 inputs. If that's outside the scope of this ticket, it could be considered
 on another.

 I also noticed that the extra border occurred in a version earlier than
 trunk (5.4.2).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50686#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform