[wp-trac] [WordPress Trac] #50434: Replace the `$new_whitelist_options` variable with a more inclusive name
WordPress Trac
noreply at wordpress.org
Mon Jul 13 19:59:35 UTC 2020
#50434: Replace the `$new_whitelist_options` variable with a more inclusive name
--------------------------+---------------------
Reporter: desrosj | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.5
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
--------------------------+---------------------
Comment (by SergeyBiryukov):
Replying to [comment:7 desrosj]:
> I think a more conservative approach like the one in the current patch
would be best for 5.5, and maybe we could outline the plan to add
`_deprecated_global()` and officially deprecate `$new_whitelist_options`
in 5.6?
Makes sense to me.
Noticed a couple of typos in the PR:
* `$new_whiltelist_options` (extra "l") in the `@since` note.
* The inline comments should start with `/*`, not `/**` (the latter is for
proper DocBlocks).
Looks good otherwise.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/50434#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list