[wp-trac] [WordPress Trac] #9757: Allow Plugin/Theme updates from a uploaded .zip file.
WordPress Trac
noreply at wordpress.org
Mon Jul 13 13:38:44 UTC 2020
#9757: Allow Plugin/Theme updates from a uploaded .zip file.
-------------------------------------------------+-------------------------
Reporter: hakre | Owner: azaozz
Type: feature request | Status: closed
Priority: high | Milestone: 5.5
Component: Upgrade/Install | Version: 2.8
Severity: normal | Resolution: fixed
Keywords: dev-feedback has-patch early needs- | Focuses: ui, ui-
dev-note commit | copy
-------------------------------------------------+-------------------------
Comment (by SergeyBiryukov):
Replying to [comment:179 azaozz]:
> Replying to [comment:178 SergeyBiryukov]:
> > Personally, I find @jrf's proposal more readable than the alternative,
and tend to use the proposed formatting in my commits since the post was
published. It's already used in quite a few places in core :)
>
> I don't have any (strong) preferences, but if it's used for `if()` then
it should also be used for `sprintf()`, `array()`, etc. The inconsistency
is no good imho :)
To clarify a bit, I don't have a strong preference on `if` being on its
own line, that just seemed more consistent with what's already in core. I
do, however, have a strong preference on the boolean/logical operators
between the statements being placed at the start of the line, rather than
at the end. That's what I find more readable :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/9757#comment:183>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list