[wp-trac] [WordPress Trac] #9757: Allow Plugin/Theme updates from a uploaded .zip file.
WordPress Trac
noreply at wordpress.org
Mon Jul 13 00:24:21 UTC 2020
#9757: Allow Plugin/Theme updates from a uploaded .zip file.
-------------------------------------------------+-------------------------
Reporter: hakre | Owner: azaozz
Type: feature request | Status: closed
Priority: high | Milestone: 5.5
Component: Upgrade/Install | Version: 2.8
Severity: normal | Resolution: fixed
Keywords: dev-feedback has-patch early needs- | Focuses: ui, ui-
dev-note commit | copy
-------------------------------------------------+-------------------------
Comment (by afragen):
Replying to [comment:180 azaozz]:
> Replying to [comment:177 afragen]:
>
> > In that case, wouldn’t it make more sense to use `isset()`?
>
> Guess that's more of a "personal coding habits"? :)
>
> `isset()` is good in some cases, but if you are expecting a value and
doing something with it, it's better to "move on" straight away with `!
empty()` instead of running more code, calling functions, etc.
In this case the `is_*_version_compatible()` also does a check for
`empty()`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/9757#comment:181>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list