[wp-trac] [WordPress Trac] #49715: Alternate views for WP List Tables
WordPress Trac
noreply at wordpress.org
Fri Jul 10 19:52:56 UTC 2020
#49715: Alternate views for WP List Tables
----------------------------+--------------------------------
Reporter: joedolson | Owner: audrasjb
Type: task (blessed) | Status: reopened
Priority: normal | Milestone: 5.5
Component: Administration | Version:
Severity: normal | Resolution:
Keywords: needs-patch | Focuses: ui, accessibility
----------------------------+--------------------------------
Comment (by SergeyBiryukov):
Replying to [comment:36 Offereins]:
> @SergeyBiryukov If I'm reading [48424] correctly, renaming of the
`excerpt` mode is now only undone in `WP_MS_Users_List_Table` but not in
`WP_Posts_List_Table`.
Just to clarify, [48424] didn't touch any of the renaming parts, it only
moved that code block higher up for consistency with
`WP_MS_Sites_List_Table`.
Good catch though, there are still some references to the old `excerpt`
key, specifically:
* In `wp_ajax_inline_save()`.
* In `WP_MS_Sites_List_Table::prepare_items()`.
* In `WP_MS_Users_List_Table::prepare_items()`.
Either these all should be updated to use new `extended` mode, or all the
other instances should be reverted back to the `excerpt` mode for backward
compatibility.
> Also, the `$mode = apply_filters( 'table_view_mode', $mode );` part is
now kept in the `get_table_classes()` method. Perhaps the filter is better
applied where `$mode` is defined when the user setting is fetched in the
`prepare_items()` method.
Yes, it would also be a good idea to better document the purpose of the
filter. At the moment, it's not quite clear whether it just allows to
choose between `list` and `extended`, or also allows for specifying any
custom type. Apparently the former is the case.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/49715#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list