[wp-trac] [WordPress Trac] #48894: Improve the small user sub window at the right corner on the admin bar a.k.a. the Howdy fly-out

WordPress Trac noreply at wordpress.org
Fri Jul 10 00:49:09 UTC 2020


#48894: Improve the small user sub window at the right corner on the admin bar
a.k.a. the Howdy fly-out
-------------------------------------+-------------------------------------
 Reporter:  ixkaito                  |       Owner:  afercia
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.6
Component:  Toolbar                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  ui, accessibility,
  screenshots needs-refresh          |  javascript
-------------------------------------+-------------------------------------

Comment (by noisysocks):

 The code in [attachment:"48894.8.diff"] looks good to me and the change
 seems to work well when I test locally. Some very minor notes:

 - Code style: The `addEventListener` calls on line 71 and 72 need spaces
 within the `()`s.
 - It would be nice to tell the reader using an inline comment what key has
 key code 32.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48894#comment:71>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list