[wp-trac] [WordPress Trac] #50190: Search query doesnot know if the theme is already updated.
WordPress Trac
noreply at wordpress.org
Wed Jul 8 18:12:34 UTC 2020
#50190: Search query doesnot know if the theme is already updated.
--------------------------+---------------------------------
Reporter: sanzeeb3 | Owner: (none)
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: Future Release
Component: Themes | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: ui, administration
--------------------------+---------------------------------
Changes (by desrosj):
* keywords: has-patch needs-testing reporter-feedback => has-patch
* status: closed => reopened
* resolution: worksforme =>
* milestone: Awaiting Review => Future Release
Comment:
Hi @sanzeeb3,
Welcome to Trac! And nice find here.
I am reopening this ticket as the change has not been committed to the
codebase yet. The `worksforme` resolution is confusing, and we are
actually [https://make.wordpress.org/core/2020/06/24/proposal-rename-
invalid-worksforme-and-wontfix-ticket-resolutions/ considering updating
them to be more clear].
I've been able to confirm the bug using `trunk`, so this still exists.
This issue also reminds me of #50291, which addressed the auto-update
state not being updated across the various views of the theme. There
[https://core.trac.wordpress.org/browser/trunk/src/js/_enqueues/wp/theme.js#L647
already seems to be a function] that runs on `wp-theme-update-success` and
tries to update `version` and `hasUpdate`. I'm wondering why that is not
working correctly. That action is triggered right below where your patch
is adding code.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/50190#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list