[wp-trac] [WordPress Trac] #49843: Twenty Nineteen: Fix editor style compatibility with Gutenberg 7.7 and above
WordPress Trac
noreply at wordpress.org
Wed Jul 8 14:18:35 UTC 2020
#49843: Twenty Nineteen: Fix editor style compatibility with Gutenberg 7.7 and
above
---------------------------+---------------------
Reporter: kjellr | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.5
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: needs-testing | Focuses:
---------------------------+---------------------
Comment (by kjellr):
Thank you for reviewing, @poena! 🙌
> Right aligned text inside groups does not align
Since this only effects the front end, I think we can handle it
separately. So far, this PR only touches editor styles.
> The left spacing for the inner content of the full width group block is
not the same in the editor and the front, and does not match the wide
group block.
Good catch! Some of the full-width Group block styles were not being
correctly picked up there. Should be fixed as of
[attachment:"49843.5.patch"]:
[[Image(https://cldup.com/B0x5j6HrQI.png)]]
> Chrome 83.0.4103.116:
> I do not see the horizontal scroll in the editor in the image tests.
>
> I do see a horizontal scroll in the editor at 767px when the standard
and wide group block widths are stretched to the same width.
>
> Firefox 78.0.1:
> I do see the horizontal scroll in the editor in the image tests at
767px.
I see that too — I can reproduce by making a full-width Group block and
then putting anything else inside it. But the weird thing is that in some
cases, the scrollbars disappear when I select the block. 🙃
I haven't yet been able to pin down the cause, but I'm wondering if it
makes sense to push this for now and tackle that separately. I'd rather
not hold up all these changes just because of that.
Does that seem reasonable to you folks too?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/49843#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list