[wp-trac] [WordPress Trac] #49715: Alternate views for WP List Tables
WordPress Trac
noreply at wordpress.org
Tue Jul 7 21:05:16 UTC 2020
#49715: Alternate views for WP List Tables
----------------------------+--------------------------------
Reporter: joedolson | Owner: audrasjb
Type: task (blessed) | Status: reopened
Priority: normal | Milestone: 5.5
Component: Administration | Version:
Severity: normal | Resolution:
Keywords: needs-patch | Focuses: ui, accessibility
----------------------------+--------------------------------
Comment (by Offereins):
Reading the recent changeset I'd like to ask the following:
* Couldn't `$mode_class = 'extended' === $mode ? 'table-view-extended' :
'table-view-' . $mode;` be more like `$mode_class = 'table-view-' .
$mode;` or interpolated as `$mode_class = "table-view-{$mode}";`?
* For the sake of (future) consistency, should a registration pattern for
modes (eg `array( key => label )`) not be better suited? The new hooks
(looking at `wp_table_view_modes`) provide a lot of room for deviations in
HTML markup. Might I suggest to use a filterable list of modes, which
would allow for removing modes and reordering modes, as well as a
consistent output of HTML markup handled by core.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/49715#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list