[wp-trac] [WordPress Trac] #50346: Make delete plugin message less scary

[WordPress Trac]

#50346: Make delete plugin message less scary
-------------------------------------+-----------------------------
 Reporter:  joostdevalk              |       Owner:  SergeyBiryukov
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  5.5
Component:  Plugins                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * type:  enhancement => defect (bug)


Comment:

 Replying to [ticket:50346 joostdevalk]:
 > Can we make that string dependent on whether the plugin actually is an
 uninstallable plugin, per `is_uninstallable_plugin`?

 I remember this was the case in older releases. There are already some
 `is_uninstallable_plugin()` checks in the code, it looks like they don't
 work as expected or something is missing to leverage them properly.

 So this appears to a be a regression in recent releases, presumably in
 Shiny Updates introduced in #29820 and #31773. Reclassifying as a bug.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50346#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform