[wp-trac] [WordPress Trac] #50536: Fix link colors for admin schemes that personalize it using the $link SASS variable

WordPress Trac noreply at wordpress.org
Tue Jul 7 09:44:01 UTC 2020


#50536: Fix link colors for admin schemes that personalize it using the $link SASS
variable
----------------------------+--------------------------
 Reporter:  youknowriad     |       Owner:  youknowriad
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  5.5
Component:  Administration  |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:  css
----------------------------+--------------------------
Changes (by afercia):

 * keywords:  has-patch => needs-patch
 * status:  closed => reopened
 * version:  5.4 => trunk
 * resolution:  fixed =>


Comment:

 [48332] introduced a regression: some "destructive action" buttons aren't
 red any longer, ''in all the color schemes''.

 This happens because now `button-link` from the color schemes overrides
 `button-link-delete`.

 Red destructive action controls are a well established convention in core,
 as any potentially action that deletes content should be visually well
 distinguished.

 See attached screenshot for the destructive action in the Widgets. Happens
 also in the customizer.

 Worth also reminding that when changing variables in the `_admin.scss`
 file, the change will likely impact plugins that extend the color schemes.
 At the very least, this change should have a dev-note.

 Reopening as the red color for destructive action should be restored.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50536#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list