[wp-trac] [WordPress Trac] #50448: Add tolerance to plugin and theme auto-update failure emails

WordPress Trac noreply at wordpress.org
Mon Jul 6 16:20:25 UTC 2020


#50448: Add tolerance to plugin and theme auto-update failure emails
-------------------------------------+---------------------
 Reporter:  desrosj                  |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  5.5
Component:  Administration           |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------

Comment (by desrosj):

 @arpitgshah Yes, I reviewed that with [https://github.com/WordPress
 /wordpress-
 develop/pull/374/commits/c33f9126b84e073ae0c35cc50d5a2d27c393c9be#diff-
 ee47ab8aa25b01165fe4505c1d669e13R981-R1014 context in the latest commit
 made on the PR] before pushing some changes.

 The problem with that code is the `send_plugin_theme_email()` function is
 only called when an auto-update is attempted or applied. A user clicking
 update in the admin would never run that code, so the previous failure
 tracked within the option would remain. Additionally, it only has
 knowledge of the updates attempted during the current auto-update process.

 The updates included in the latest push to the PR/patch attached here will
 clear the plugin or theme out of the option if a user clicks update
 anywhere in the dashboard.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50448#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list