[wp-trac] [WordPress Trac] #50538: WP_Comments_List_Table should not show views that have a count of 0

WordPress Trac noreply at wordpress.org
Sun Jul 5 15:47:24 UTC 2020


#50538: WP_Comments_List_Table should not show views that have a count of 0
---------------------------------------+-----------------------------
 Reporter:  pbiron                     |       Owner:  pbiron
     Type:  enhancement                |      Status:  assigned
 Priority:  normal                     |   Milestone:  5.5
Component:  Comments                   |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  administration
---------------------------------------+-----------------------------

Comment (by pbiron):

 Hi @chetan200891, thanx for the patch.  I'm working on this right now
 myself.

 For this list table, there is JS (in `/wp-admin/js/edit-comment.js`) that
 updates the counts for the views when comments are
 approved/unapproved/marked as spam/etc.  And if the views with initial
 counts of 0 are simply not output, then that JS ends up making the counts
 seem inconsistent when comments approved/unapproved/etc :-(

 I close to having the JS (and 1 change in `/wp-admin/css/common.css`)
 updated to work correctly...we'll see if I can get it completely working
 :-)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50538#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list