[wp-trac] [WordPress Trac] #50508: Customize: Widgets appear "inactive" by default

WordPress Trac noreply at wordpress.org
Sat Jul 4 17:00:03 UTC 2020


#50508: Customize: Widgets appear "inactive" by default
---------------------------------------+-------------------------
 Reporter:  afercia                    |       Owner:  (none)
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  5.5
Component:  Customize                  |     Version:  trunk
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  javascript
---------------------------------------+-------------------------
Changes (by dlh):

 * keywords:  has-screenshots => has-screenshots has-patch


Comment:

 Introduced, I think, in [47550] with the change to a strict `in_array()`
 check in `\WP_Customize_Widgets::is_widget_rendered()`.

 The `rendered_widgets` property is an associative array of `'widget-id' =>
 true`, so the previous loose check was actually also incorrect — it
 loosely compared the widget ID to `true`. Since the widget ID is the key,
 a `! empty()` should cover it.

 @afercia would you mind testing [attachment:"50508.diff"]?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50508#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list