[wp-trac] [WordPress Trac] #49288: Metabox holders missing their border and "Drag boxes here" text

WordPress Trac noreply at wordpress.org
Sat Jul 4 09:26:58 UTC 2020


#49288: Metabox holders missing their border and "Drag boxes here" text
-------------------------------------+-------------------------------------
 Reporter:  xkon                     |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  reviewing
 Priority:  normal                   |   Milestone:  5.5
Component:  Administration           |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  ui, accessibility,
  screenshots                        |  administration
-------------------------------------+-------------------------------------

Comment (by afercia):

 Thanks @azaozz ! Will try to check all your points:

 First:
 > doesn't work on the old Edit Post screen (need Classic Editor to test).
 When there are no boxes under the editor, or when all of them are
 (visibly) hidden, you cannot drag a box from the side to under the editor.

 Seems to work for me. See attached animated GIF. I do know the sortables
 drop areas need a height to work correctly. That is why a `min-height` is
 added ''while dragging''. However, I do see that when "hovering" a drop
 area, the "placeholder" appears only when you move a bit around the drop
 area. This is clearly visible also in the GIF. The placeholder should
 appear immediately and probably a height needs to be set earlier.

 On the other hand, there's the need to reset the height inherited from
 common.css otherwise there will be a huge blank space below the editor.

 I experimented a bit and looks like the sortables need ''any'' initial
 height to work better: even a 1 pixel initial height seems to improve
 things. Then, when dragging, `min-height: 60px;` makes the drop areas
 height bigger. Of course, we can adjust these numbers if necessary. Patch
 incoming.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49288#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list