[wp-trac] [WordPress Trac] #49288: Metabox holders missing their border and "Drag boxes here" text

[WordPress Trac]

#49288: Metabox holders missing their border and "Drag boxes here" text
-------------------------------------+-------------------------------------
 Reporter:  xkon                     |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  reviewing
 Priority:  normal                   |   Milestone:  5.5
Component:  Administration           |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  ui, accessibility,
  screenshots                        |  administration
-------------------------------------+-------------------------------------
Changes (by azaozz):

 * keywords:  has-patch has-screenshots commit => has-patch has-screenshots


Comment:

 Replying to [comment:33 afercia]:
 > - please double check the removed check for `visible == 1` as I'm not
 sure I understand ~~why it was there in the first place~~ [edit] whether
 it's still used (it was introduced in [20272])

 Hmm, can't remember (it was 8 years ago!). Seems it had something to do
 with hiding the outlines for empty drop areas on the Dashboard when there
 is only one "box" available for dragging. Then it doesn't make sense to
 show other areas as there's nothing to move there.

 49288.7.diff seems to work well on the Dashboard, but doesn't work on the
 old Edit Post screen (need Classic Editor to test). When there are no
 boxes under the editor, or whgen all of them are (visibly) hidden, you
 cannot drag a box from the side to under the editor.

 Seem caused by
 {{{
 #normal-sortables.empty-container, #post-body #advanced-sortables.empty-
 container {
     height: auto;
     ...
 }}}

 For Sortables the drop area has to have width and height before you start
 to drag, or there's nowhere to drop. Removing the above CSS seem to fix
 it.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49288#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform