[wp-trac] [WordPress Trac] #50448: Add tolerance to plugin and theme auto-update failure emails
WordPress Trac
noreply at wordpress.org
Thu Jul 2 20:02:20 UTC 2020
#50448: Add tolerance to plugin and theme auto-update failure emails
------------------------------------+---------------------
Reporter: desrosj | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.5
Component: Administration | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch dev-feedback | Focuses:
------------------------------------+---------------------
Comment (by desrosj):
I've been working through this one over on GitHub with @arpitgshah. My
[https://github.com/WordPress/wordpress-
develop/pull/374#pullrequestreview-441976846 latest push to that PR] has
some refined code I think is getting close.
I took the following approach:
- When a failure email is being sent, only send an email if there is a
**new** failure in the list. When there is a new failure in the list, the
email needs to go out anyways, so it's OK to include other failures that
may have been sent too recently.
- When a mixed email is sent, that means there are new successful updates.
An email is going out anyways for those updates, so include the failure
info as well (even if it is too recent).
The only scenario that is not addressed in the recent patch is when the
user goes manually applies an update, whether through clicking update in
the dashboard or by uploading a new version of the plugin or theme
manually.
For the first scenario, it would probably be an edge case for someone to
update a plugin and then have a failure within 3 days. But if the interval
is filtered to a larger number, it could be more common. The new option
can probably be checked when plugins upgrade manually as well.
For the second scenario, I don't know that there is a standardized way to
tell if a new plugin version was updated manually. but I could be wrong.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/50448#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list