[wp-trac] [WordPress Trac] #48170: Switch link list widgets to nav blocks

[WordPress Trac]

#48170: Switch link list widgets to nav blocks
--------------------------------------+----------------------------
 Reporter:  joedolson                 |       Owner:  audrasjb
     Type:  enhancement               |      Status:  accepted
 Priority:  normal                    |   Milestone:  5.5
Component:  Widgets                   |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch needs-dev-note  |     Focuses:  accessibility
--------------------------------------+----------------------------
Changes (by afercia):

 * keywords:  has-patch dev-feedback needs-dev-note => has-patch needs-dev-
     note


Comment:

 [attachment:"48170.5.diff"] fixes the remaining PHPCS issues. Please
 double check.

 Testing the patch, there's a main accessibility issue that should be
 fixed. All the `<nav>` elements are unlabelled. When there are multiple
 navigation landmarks on a page, those need to be labelled otherwise screen
 reader users would get a series of "navigation" landmarks with no clue
 what these landmarks are about. See screenshots.

 To fix this, all the `<nav>` elements should use an `aria-label` attribute
 to give them a proper name:
 - use the user-entered widget title
 - if the user-entered widget title is empty, fallback to a meaningful
 title
 - note that I think some of these widgets already use a fallback title
 (which may or may not be ideal)


 Also:
 - I see we're still using the pattern `<nav role="navigation">`: this is
 historically used to support old assistive technologies: do we still want
 to use the redundant role?
 - is `navigation` a good name for the new HTML5 supported property?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48170#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform