[wp-trac] [WordPress Trac] #21676: Pass a variable to get_template_part()
WordPress Trac
noreply at wordpress.org
Wed Jul 1 23:06:15 UTC 2020
#21676: Pass a variable to get_template_part()
-------------------------------------+------------------------------
Reporter: sc0ttkclark | Owner: SergeyBiryukov
Type: enhancement | Status: reviewing
Priority: normal | Milestone: Awaiting Review
Component: Template | Version: 3.4.1
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses:
-------------------------------------+------------------------------
Comment (by audrasjb):
Hi,
Just to add my two cents on this:
- I tested `21676.13.diff` and it works fine on my side.
- About the use of `$args`/`extract()`: I don't have the full background
on what is "discouraged" so far, but using `$args` looks fine to me.
- It would be really great to get this in WP 5.5. Can I suggest to move
this ticket to the related milestone? We're still in Alpha cycle for few
days and it would be a great enhancement. I don't think there is any
security issue with the current approach, so in the worst scenario where
we finally need to revert it, it's still safe for WordPress instances that
run trunk.
ps: I didn't remove `needs-testing` workflow keyword, since other may want
to add the results of their tests as well…
--
Ticket URL: <https://core.trac.wordpress.org/ticket/21676#comment:98>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list