[wp-trac] [WordPress Trac] #47136: Image Editor: Reading and focus order do not match visual order

[WordPress Trac]

#47136: Image Editor: Reading and focus order do not match visual order
-------------------------------------------------+-------------------------
 Reporter:  anevins                              |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.5
Component:  Media                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots wpcampus-report      |     Focuses:  ui,
  has-patch needs-dev-note commit                |  accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  has-screenshots wpcampus-report has-patch needs-dev-note =>
     has-screenshots wpcampus-report has-patch needs-dev-note commit


Comment:

 I couldn't find a better way to determine when the image editor is "fully
 loaded" so the `setTimeout()` approach is good enough.

 In [attachment:"47136.4.diff"]:
 - moved the focus management out from `imgLoaded()` and into a new
 specific `focusManager()` function so that the functions responsibilities
 are clearer
 - abstracted the retrieval of the first element to move focus to by the
 means of jQuery UI `:tabbable` so that focus will always be placed on the
 first tabbable element within the image editor, whatever it is

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47136#comment:52>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform