[wp-trac] [WordPress Trac] #39311: New user activation welcome page links to the wrong site

WordPress Trac noreply at wordpress.org
Wed Jul 1 00:28:08 UTC 2020

#39311: New user activation welcome page links to the wrong site
 Reporter:  tmoore41                             |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.5
Component:  Login and Registration               |     Version:  4.7
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-       |     Focuses:  multisite
  refresh                                        |

Comment (by pkarjala):

 @whyisjake Can you please clarify in what manner you'd like
 `add_query_arg` to be used in the context of the proposed changes?

 As it stands, the `$blog_details->path` addendum to the URL is not a query
 argument to `wp_lostpassword_url`, but a change of the base URL being
 used, based on which subsite the user is on when they go to reset their
 password.  It may also be the case that we ALSO want it to be part of the
 redirect path; if this is the case, I will change the code to include it.

 I apologize if I am not understanding the request correctly, and
 appreciate any clarification.

 I have cleaned up the `sprintf` usage to be:

 `sprintf( '<a href="http://%1$s%2$s">%1$s%2$s</a>', $signup->domain,
 $blog_details->path ),`

 which removes the problematic concatenation.

 Once I have clarification for the first item, I will upload the refreshed

Ticket URL: <https://core.trac.wordpress.org/ticket/39311#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list