[wp-trac] [WordPress Trac] #46894: Personal Data Export Report: Table of contents for easier navigation

[WordPress Trac]

#46894: Personal Data Export Report: Table of contents for easier navigation
-------------------------------------------------+-------------------------
 Reporter:  birgire                              |       Owner:  xkon
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.4
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:  ui
  testing has-unit-tests                         |
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):

 * keywords:  has-screenshots has-patch commit => has-screenshots has-patch
     needs-testing has-unit-tests


Comment:

 Thanks @xkon I did some additional testing and everything works nicely.
 Tried with a couple plugins as well as applied the patches for Community
 Events Location (#43921) and Sessions Tokens (#45889) which added to the
 TOC properly.

 The only question/improvement that came to mind while reviewing is the
 group count. For Session Tokens, Comments and other groups there can be
 multiple items. These groups have a group count applied beside the title
 which was introduced in [https://core.trac.wordpress.org/changeset/46209
 Changeset#46209] / [https://core.trac.wordpress.org/ticket/46895
 Ticket#46895].

 In [https://core.trac.wordpress.org/attachment/ticket/46894/46894.6.diff
 46894.6.diff] I've added the following;
 - Group Count to TOC groups with multiple items
 - Unit Tests for Group Count and TOC
 - Suppressed Return To Top when only 1 group (About) (This passes a
 $groups_count param on the
 `wp_privacy_generate_personal_data_export_group_html` function so updated
 relevant Unit Tests).

 Can you take a look and make sure you're happy with the addition of Group
 Count to TOC and suppression of Return to Top on single group exports
 please @xkon. I removed commit as there was several changes so just
 another set of eyes would make me happy to move it back to commit.
 Thanks

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46894#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform