[wp-trac] [WordPress Trac] #48431: Privacy policy notice should not be visible on Draft Admin List page.

[WordPress Trac]

#48431: Privacy policy notice should not be visible on Draft Admin List page.
-------------------------------------------------+-------------------------
 Reporter:  chetan200891                         |       Owner:  garrett-
                                                 |  eclipse
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.4
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:  ui,
  refresh                                        |  administration
-------------------------------------------------+-------------------------
Changes (by xkon):

 * keywords:  has-screenshots has-patch commit => has-screenshots has-patch
     needs-refresh


Comment:

 Hey @chetan200891 ! Thanks for pointing this out and the patch. I'm
 removing the commit for now for a bit of extra discussion first.

 The current [attachment:"48431.diff"] works fine (could have used strict
 comparison but that's easily changed).

 Since there can only be 1 Privacy Policy page at a time and we always keep
 its ID at the `wp_page_for_privacy_policy` option I believe it would be
 better to bind this notice only to that ID + editing (post.php) page if
 that's possible.

 This way the notice will only show up under these specific circumstances
 instead of excluding unwanted side-effects like the Draft list view.

 Would you like to see if that would work and come up with an new patch?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48431#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform