[wp-trac] [WordPress Trac] #49331: 'output' Taxonomy Slug Crashes Menu

[WordPress Trac]

#49331: 'output' Taxonomy Slug Crashes Menu
--------------------------+------------------------------
 Reporter:  nekokun       |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Menus         |     Version:  5.3.2
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------
Changes (by SergeyBiryukov):

 * component:  Taxonomy => Menus


Comment:

 Hi there, welcome to WordPress Trac! Thanks for the report.

 I was able to reproduce the issue. It happens because
 `wp_get_nav_menu_items()` has an [source:tags/5.3.2/src/wp-includes/nav-
 menu.php?marks=664,691,699#L654 `output` parameter], which is passed to
 `get_posts()` along with other parameters, and conflicts with the taxonomy
 of the same name.

 A couple of ways to resolve this:
 * Only pass the parameters `get_posts()` actually accepts, i.e. exclude
 `output` and `output_key`.
 * Add `output` to the list of reserved terms.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49331#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform