[wp-trac] [WordPress Trac] #49288: Metabox holders missing their border and "Drag boxes here" text

[WordPress Trac]

#49288: Metabox holders missing their border and "Drag boxes here" text
-------------------------------------+-------------------------------------
 Reporter:  xkon                     |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  reviewing
 Priority:  normal                   |   Milestone:  5.4
Component:  Administration           |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, accessibility,
  has-screenshots needs-design-      |  administration
  feedback                           |
-------------------------------------+-------------------------------------

Comment (by xkon):

 Thanks for going even further back and pinpointing a commit @afercia!

 I was aware of the `start()` `stop()` but I didn't have an idea on how to
 use them. The color correction to `#606a73` gave me the idea though that
 instead of having them hidden/visible on drag we could also make them even
 more visible and a11y friendly since the border is still at `#b4b9be`
 which isn't a good difference with the background also.

 The changes in the [attachment:"49288.2.diff"] are re-introducing the
 older `min-height:20px` on advanced-sortables as well as adjusting the
 `Drag boxes here` to permanently use `#606a73`.

 Also adds/removes the `is-dragging-metaboxes` class on drag/drop which
 also adjusts the border color to `#606a73` as well. This way we tackle
 both a visual hint and also making it compatible to standards.

 Side note: I did also play around with fully hiding the sortables while
 empty and show them on drag but this was resulting either on "flickering"
 of the screen if the height was also changed ( i.e. with a display:none or
 height: 20px) or you just ended up having a huge gap at the end of the
 page that didn't look nice :-). That's why I ended up just bumping the
 border color to have the best of both.

 Preview [attachment:"49288.2_preview.gif"]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49288#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform