[wp-trac] [WordPress Trac] #48154: Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build
WordPress Trac
noreply at wordpress.org
Tue Jan 28 18:35:44 UTC 2020
#48154: Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build
-------------------------------------------------+-------------------------
Reporter: gziolo | Owner: gziolo
Type: enhancement | Status: reopened
Priority: normal | Milestone: 5.4
Component: Script Loader | Version: trunk
Severity: normal | Resolution:
Keywords: dev-feedback needs-patch 2nd- | Focuses: javascript
opinion |
-------------------------------------------------+-------------------------
Comment (by pbearne):
The code has a test for file exist for the js but not for the PHP file so
if the npm build:dev or main build has not been run correctly it errors (
as seen in the errors above)
I wonder if it would not be better to test for the PHP file and not the JS
as the PHP file is created if the JS is there ( this is less expensive
than testing for both )
We should/could throw an error message if we are missing a PHP file
instructing the DEV to run npm build:dev
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48154#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list