[wp-trac] [WordPress Trac] #49264: Consider a redesign for the Policy Settings page (includes Policy Guide and future Disclosures & Policies)

WordPress Trac noreply at wordpress.org
Tue Jan 28 13:11:20 UTC 2020


#49264: Consider a redesign for the Policy Settings page (includes Policy Guide and
future Disclosures & Policies)
-------------------------------------+-------------------------------------
 Reporter:  xkon                     |       Owner:  xkon
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  Future Release
Component:  Privacy                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  needs-design-feedback    |     Focuses:  ui, accessibility,
  has-patch 2nd-opinion needs-docs   |  administration, privacy
  needs-dev-note                     |
-------------------------------------+-------------------------------------
Changes (by xkon):

 * keywords:  needs-design-feedback has-patch 2nd-opinion => needs-design-
     feedback has-patch 2nd-opinion needs-docs needs-dev-note


Comment:

 After going over and over iterating on the array of my previous comments,
 I realized that there's no point of changing the current functionality and
 introduce back-compat issues "just for a text". Also if any author wanted
 multidimensional nesting it would be hard to follow after a point.

 [attachment:"49264.5.diff"] takes a different approach on the Policy text
 by introducing just another "needed" class. At the moment the "Suggested"
 text was not using any class at all so it was hard to define and target it
 for easier usage either for CSS or copy/paste reasons etc.

 Instead we can now use 2x classes. `privacy-policy-tutorial` (existing for
 general text) and the new `privacy-policy-suggested-text` for any
 suggestion related text.

 I've also altered the `get_default_content()` to split our default policy
 text into an actual Guide and also as an incoming suggestion. This makes
 it easier to understand as you're not seeing everything in 1 read from
 Core and you can simply read the Guide only if you need to do so.

 In this patch `wp_get_default_privacy_policy_content` filter is also
 getting deprecated. I'm not entirely sure why this was added but
 unfortunately I've seen a couple of plugins hooking there instead of using
 the correct `wp_add_privacy_policy_content`, resulting on
 changing/extending the Core guide + suggestions. Which IMHO is wrong and
 shouldn't happen. The guide and core suggestions should only be Cores
 responsibility with no way of altering them.

 Preview at [attachment:"49264.5_preview.gif"] .

 @azaozz, this is a patch for a future release (if accepted) so it can
 definitely wait for now, but I'd love to hear your thoughts and any
 pointers before continuing especially regarding the deprecation, whenever
 you find some time :-).

 --

 Todo:
 If/when this patch is implemented we will have to add some extra CSS rules
 for back-compat with the existing ones and update the `Copy to clipboard`
 functionality to support both if possible.

 Side note:
 It seems that we totally missed of informing the Authors about how to
 properly write their Policy in general as there's no mention at all about
 classes and correct text convention at
 https://developer.wordpress.org/plugins/privacy/suggesting-text-for-the-
 site-privacy-policy/ .

 We should be updating those docs in any case and explaining that it would
 be for the best to start with `<h2>` and smaller headings, as well as
 regarding the correct `<p>` and their classes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49264#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list