[wp-trac] [WordPress Trac] #43895: Organize privacy functions into logical files and classes
WordPress Trac
noreply at wordpress.org
Tue Jan 28 00:59:03 UTC 2020
#43895: Organize privacy functions into logical files and classes
-----------------------------+----------------------
Reporter: iandunn | Owner: desrosj
Type: enhancement | Status: closed
Priority: normal | Milestone: 5.3
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution: fixed
Keywords: early has-patch | Focuses:
-----------------------------+----------------------
Comment (by garrett-eclipse):
Replying to [comment:51 azaozz]:
> Wondering if we should also move the `_wp_privacy-*` and user request
related functions from `wp-includes/user.php`:
https://github.com/WordPress/wordpress-
develop/blob/0af549fdf50ac779fb68cc0bd688ac283d5195ec/src/wp-
includes/user.php#L2840-L3650. They are user related, but for both
registered and non-registered (website) users. Perhaps `user.php` is a
good place anyway.
Hi @azaozz sorry to resurface this ticket. I was working on #46536 and
found the `_wp_privacy_action_request_types` function remains in the
user.php but is only ever referenced from the privacy-tools.php and was
wondering if we should move that function there to keep it contained
within the file it's reference from.
Also I do like the idea of isolating the user privacy functions, maybe
into a user-privacy.php. But that being said `user.php` is also a valid
location as they are user related.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43895#comment:57>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list