[wp-trac] [WordPress Trac] #44197: ZIP file containing a user’s personal data has user’s personal data in filename

[WordPress Trac]

#44197: ZIP file containing a user’s personal data has user’s personal data in
filename
--------------------------+------------------------------
 Reporter:  Ov3rfly       |       Owner:  garrett-eclipse
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  5.4
Component:  Privacy       |     Version:  4.9.6
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------------
Changes (by xkon):

 * keywords:  has-patch needs-testing => has-patch


Comment:

 [attachment:"44197.3.diff"] looks good to me and didn't see any hiccups
 while testing also so I'm +1 for `commit` tag.

 Regarding PHPUnit that I mentioned we're using hardcoded names on some
 occasions.

 See `\tests\phpunit\tests\privacy\wpPrivacyDeleteOldExportFiles.php` lines
 59-60

 {{{
 self::$expired_export_file = $exports_dir . 'wp-personal-data-file-user-
 at-example-com-0123456789abcdef.zip';
 self::$active_export_file  = $exports_dir . 'wp-personal-data-file-user-
 at-example-com-fedcba9876543210.zip';
 }}}


 `\tests\phpunit\tests\privacy\wpPrivacyProcessPersonalDataExportPage.php`
 line 134
 {{{
 self::$export_file_url      = wp_privacy_exports_url() . 'wp-personal-
 data-file-requester-at-example-com-Wv0RfMnGIkl4CFEDEEkSeIdfLmaUrLsl.zip';
 }}}

 `tests\phpunit\tests\privacy\wpPrivacySendPersonalDataExportEmail.php`
 line 107
 {{{
 $archive_url = wp_privacy_exports_url() . 'wp-personal-data-file-
 requester-at-example-com-Wv0RfMnGIkl4CFEDEEkSeIdfLmaUrLsl.zip';
 }}}

 It would be good to update these also just for the sake of the new naming
 convention and to avoid confusion :-).

 And I hope I didn't miss/forget anything else in there 😅.

 Care for a quick update @garrett-eclipse?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44197#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform