[wp-trac] [WordPress Trac] #44197: ZIP file containing a user’s personal data has user’s personal data in filename

[WordPress Trac]

#44197: ZIP file containing a user’s personal data has user’s personal data in
filename
--------------------------+---------------------
 Reporter:  Ov3rfly       |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.4
Component:  Privacy       |     Version:  4.9.6
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+---------------------
Changes (by donmhico):

 * keywords:  has-patch needs-refresh => has-patch


Comment:

 @xkon - Updated the patch -
 [https://core.trac.wordpress.org/attachment/ticket/44197/44197.2.diff
 44197.2.diff]. I maybe wrong but I don't see any needed changes in the
 unit tests. I'm looking in
 https://core.trac.wordpress.org/browser/trunk/tests/phpunit/tests/privacy/wpPrivacyGeneratePersonalDataExportFile.php.
 The full php test suite is successful as well. Let me know if i'm missing
 anything.

 And as @Ov3rfly mentioned, there's theoretical possibility of a filename
 collision. I guess we can perform a file check first then either add an
 increment in the end of the filename or re-iterate the
 `wp_generate_password()` that generates `$obscura`.

 What do you guys think?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44197#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform